Skip to content

HIVE-27277: GH actions to build and push docker image #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

HIVE-27277: GH actions to build and push docker image #4298

wants to merge 2 commits into from

Conversation

@simhadri-g
Copy link
Member

@simhadri-g simhadri-g commented May 5, 2023

Set up github actions workflow to build and push docker image to docker hub

Hi Everyone,

I have got the docker hub repository setup for Apache hive from Infra.
https://issues.apache.org/jira/browse/INFRA-24505

DockerHub: https://hub.docker.com/r/apache/hive

In this PR I have set up GitHub actions workflow to to automatically publish the docker image to Docker hub on every release. The workflow is triggered when a rel/release-* tag is created.

The workflow was tested on a hive fork:
https://github.com/simhadri-g/hive/actions/runs/4892994049
The image was successfully pushed here by the action when a release tag was created:
https://hub.docker.com/repository/docker/simhadri064/4.0.0-snapshot/general

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@simhadri-g simhadri-g mentioned this pull request May 5, 2023
Closed
@simhadri-g
HIVE-27277: GH actions to build and push docker image
6d1e5d5 
Set up github actions workflow to build and push docker image to docker hub
dengzhhu653
dengzhhu653 reviewed May 9, 2023
View reviewed changes
packaging/src/docker/Dockerfile
ONBUILD RUN apt-get update && apt-get -y install wget
ONBUILD RUN wget https://archive.apache.org/dist/tez/$TEZ_VERSION/apache-tez-$TEZ_VERSION-bin.tar.gz && \
wget https://archive.apache.org/dist/hadoop/core/hadoop-$HADOOP_VERSION/hadoop-$HADOOP_VERSION.tar.gz && \
wget https://archive.apache.org/dist/hive/hive-$HIVE_VERSION/apache-hive-$HIVE_VERSION-bin.tar.gz
Copy link
Member

@dengzhhu653 dengzhhu653 May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: When we create a rel/release-, in Dockerfile we get the hive tarball from https://archive.apache.org/dist/hive/hive-$HIVE_VERSION/apache-hive-$HIVE_VERSION-bin.tar.gz, I'm not sure it would be there on the event rel/release- created.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Jul 22, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the [email protected] list if the patch is in need of reviews.

@github-actions github-actions bot added the stale label Jul 22, 2023
@github-actions github-actions bot closed this Jul 30, 2023
@dengzhhu653 dengzhhu653 reopened this Aug 3, 2023
@nrg4878 nrg4878 requested a review from ayushtkn August 3, 2023 14:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions github-actions bot closed this Aug 11, 2023
@simhadri-g simhadri-g mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dengzhhu653 dengzhhu653 dengzhhu653 left review comments

@ayushtkn ayushtkn Awaiting requested review from ayushtkn

Assignees

No one assigned

Labels

stale tests passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simhadri-g @dengzhhu653 @kgyrtkirk